Add reserved_words counter #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've run into an issue internally where certain applications are emitting stats with reserved words. We don't want to panic or otherwise harm the app, but we do want to be able to alert / notify owners when this is happening.
| var ReservedTagWords = map[string]bool{"asg": true, "az": true, "backend": true, "canary": true, "host": true, "period": true, "region": true, "shard": true, "window": true, "source": true, "project": true, "facet": true, "envoyservice": true} | ||
|
|
||
| func (s *statStore) validateTags(tags map[string]string) { | ||
| for k := range tags { |
There was a problem hiding this comment.
which one is usually smaller in number of elements, reserved tags or user tags?
There was a problem hiding this comment.
gooood question, i'd have to assume user tags. most of our tags get added in the enrichment pipeline
There was a problem hiding this comment.
and its nil for anything created with the non xWithTags paths
abhinavdahiya
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into an issue internally where certain applications are emitting stats with reserved words. We don't want to panic or otherwise harm the app, but we do want to be able to alert / notify owners when this is happening.
We create an additional counter here to track how often reserved_tags are being sent to statsd without blocking them.